Conversation
f41718d
to
b958757
Compare
Request for data collection review formAll questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.
|
b958757
to
2d43d49
Compare
2d43d49
to
80183bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One outstanding question
notification_emails: | ||
- fenix-core@mozilla.com | ||
expires: "2020-09-01" | ||
save_to_collection: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this save a single tab (e.g. the one you have opened/selected) to the collection? Or can you multiselect, save all, etc?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All tabs, That's how the three dot menu works as it stands :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data-review+ only
a few nits in the documentation clarity
Data Review Form (to be filled by Data Stewards)
- Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?
Yes, tabs tray telemetry is documented in the docs/metrics.md
- Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.
Yes, user can turn this off in fenix telemetry settings
- If the request is for permanent data collection, is there someone who will monitor the data over time?
has expiry
- Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?
Type 2, interaction with tabs tray
- Is the data collection request for default-on or default-off?
default on
- Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?
No
- Is the data collection covered by the existing Firefox privacy notice?
yes
- Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**
has an expiry
- Does the data collection use a third-party collection tool? If yes, escalate to legal.
no
private_mode_tapped: | ||
type: event | ||
description: | | ||
A user switched to private mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is from tabs tray only? assuming a data science person will see the whole sequence tabs_tray.private_mode_tapped then that should be fine, otherwise we might want to clarify that this doesn't include homescreen mode switching
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes tabs tray only.
normal_mode_tapped: | ||
type: event | ||
description: | | ||
A user switched to normal mode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above ^
Pull Request checklist
After merge
To download an APK when reviewing a PR: