-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Nimbus-SDK-119 Get Nimbus server endpoint at build time. #16682
Conversation
This pull request has conflicts when rebasing. Could you fix it @jhugman? 🙏 |
FIY: We just landed the AC update on |
73392ae
to
5316834
Compare
Codecov Report
@@ Coverage Diff @@
## master #16682 +/- ##
============================================
- Coverage 30.26% 30.25% -0.01%
Complexity 1231 1231
============================================
Files 455 455
Lines 18654 18658 +4
Branches 2577 2578 +1
============================================
Hits 5645 5645
- Misses 12562 12566 +4
Partials 447 447
Continue to review full report at Codecov.
|
This looks like it requires a secret URL put on taskcluster. Who would be the right person to convey this secret to to get this on to taskcluster? @pocmo ? @amedyne ? @st3fan ? |
@JohanLorenzo or @MihaiTabara can help with that, I think. What URL do we need to use (or is that actually secret?)? I may have access too, but I am not sure if I remember the right paths for all build variants on https://firefox-ci-tc.services.mozilla.com/secrets |
5316834
to
41d80c8
Compare
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
41d80c8
to
590db8b
Compare
This PR builds on AC##9024, and implements setting the Nimbus endpoints from a secret set at build time.
For production use, this requires a secret named
nimbus_url
to be put into CI.Note: Nimbus is currently behind a feature flag.
If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.:
Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment.
Pull Request checklist
To download an APK when reviewing a PR: