This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
For #8985 Fix Share Menu display when having recently used list. #9024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BranescuMihai
approved these changes
Mar 9, 2020
mcarare
changed the title
…sed list. Allow for All Actions recyclerview to scroll to end. Adjust padding for views.
Codecov Report
@@ Coverage Diff @@
## master #9024 +/- ##
============================================
- Coverage 18.9% 18.89% -0.02%
Complexity 502 502
============================================
Files 330 330
Lines 13054 13059 +5
Branches 1727 1727
============================================
- Hits 2468 2467 -1
- Misses 10377 10382 +5
- Partials 209 210 +1
Continue to review full report at Codecov.
|
jhugman
added a commit
that referenced
this pull request
Nov 20, 2020
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
jhugman
added a commit
that referenced
this pull request
Nov 20, 2020
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
jhugman
added a commit
that referenced
this pull request
Nov 20, 2020
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
jhugman
added a commit
that referenced
this pull request
Dec 3, 2020
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
jhugman
added a commit
that referenced
this pull request
Dec 3, 2020
This PR builds on [AC##9024][1], and implements setting the Nimbus endpoints from [a secret set at build time][2]. For production use, this requires a secret named `nimbus_url` to be put into CI. Note: Nimbus is currently behind a feature flag. If developers wish to use a Nimbus server for local development, you can set the url by adding an entry into local.properties, e.g.: ``` nimbus.remote-settings.url=https://settings.stage.moz4ws.net ``` Without setting server, Nimbus will be able to function, except no experimental definitions will be fetched, and features under experiment will be configured as if not enrolled in the experiment. [1]: mozilla-mobile/android-components#9024 [2]: https://groups.google.com/a/mozilla.com/g/android-components-team/c/lAGVKQy8aiA/m/rY3uGAwhBAAJ
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow for All Actions recyclerview to scroll to end.
Adjust padding for views.
Pull Request checklist
After merge
To download an APK when reviewing a PR: