Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #2205 & #1578: Integrates tab collection storage #2478

Merged
merged 2 commits into from
May 16, 2019
Merged

For #2205 & #1578: Integrates tab collection storage #2478

merged 2 commits into from
May 16, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented May 14, 2019

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

@sblatz sblatz requested a review from a team as a code owner May 14, 2019 16:52
@sblatz sblatz force-pushed the add-collections-logic branch 5 times, most recently from 24f18a3 to 8a7d584 Compare May 16, 2019 18:00
@sblatz sblatz changed the title [WIP] Add collections logic For #2205 & For #1578: Adds TabCollectionStorage May 16, 2019
@sblatz sblatz changed the title For #2205 & For #1578: Adds TabCollectionStorage For #2205 & For #1578: Integrates TabCollectionStorage May 16, 2019
@sblatz sblatz changed the title For #2205 & For #1578: Integrates TabCollectionStorage For #2205 & For #1578: Integrates tab collection storage May 16, 2019
@sblatz sblatz changed the title For #2205 & For #1578: Integrates tab collection storage For #2205 & #1578: Integrates tab collection storage May 16, 2019
@sblatz sblatz force-pushed the add-collections-logic branch 3 times, most recently from a8dabae to 64cc0eb Compare May 16, 2019 18:40
ekager
ekager approved these changes May 16, 2019
View reviewed changes
Copy link
Contributor

@ekager ekager left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sblatz sblatz merged commit 72d29c2 into mozilla-mobile:master May 16, 2019
@sblatz sblatz deleted the add-collections-logic branch May 22, 2019 20:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ekager ekager ekager approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sblatz @ekager