This repository has been archived by the owner on Feb 20, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test #25803
Merged
mergify
merged 3 commits into
mozilla-mobile:main
from
AndiAJ:redirectToAppPermissionsSystemSettingsTest
Jul 7, 2022
Merged
For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test #25803
mergify
merged 3 commits into
mozilla-mobile:main
from
AndiAJ:redirectToAppPermissionsSystemSettingsTest
Jul 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndiAJ
force-pushed
the
redirectToAppPermissionsSystemSettingsTest
branch
6 times, most recently
from
June 30, 2022 13:38
e436230
to
bd01447
Compare
AndiAJ
changed the title
Status check disabled redirectToAppPermissionsSystemSettingsTest UI test
For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test
Jun 30, 2022
sv-ohorvath
approved these changes
Jul 1, 2022
...rc/androidTest/java/org/mozilla/fenix/ui/robots/SettingsSubMenuSitePermissionsCommonRobot.kt
Outdated
Show resolved
Hide resolved
AndiAJ
force-pushed
the
redirectToAppPermissionsSystemSettingsTest
branch
6 times, most recently
from
July 1, 2022 13:47
f212cec
to
cc03423
Compare
AndiAJ
added
the
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
label
Jul 4, 2022
Flaky on the last run, will check what's going on. |
AndiAJ
force-pushed
the
redirectToAppPermissionsSystemSettingsTest
branch
3 times, most recently
from
July 5, 2022 07:09
a73c2f9
to
e42210a
Compare
Looks like in some cases the "Blocked by Android" remained displayed for "Location" even though the system permission was granted. Added ✅ Successfully passed 100x on Firebase. |
AndiAJ
force-pushed
the
redirectToAppPermissionsSystemSettingsTest
branch
from
July 5, 2022 07:14
e42210a
to
19589e1
Compare
AndiAJ
added
needs:review
PRs that need to be reviewed
and removed
pr:work-in-progress
PRs that are not ready to be reviewed yet and are actively being worked on
labels
Jul 5, 2022
This pull request has conflicts when rebasing. Could you fix it @AndiAJ? 🙏 |
AaronMT
approved these changes
Jul 6, 2022
…ettingsTest UI test
AndiAJ
force-pushed
the
redirectToAppPermissionsSystemSettingsTest
branch
from
July 6, 2022 14:44
19589e1
to
471a99f
Compare
AndiAJ
added
pr:needs-landing
PRs that are ready to land [Will be merged by Mergify]
and removed
needs:review
PRs that need to be reviewed
labels
Jul 6, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #25034 fix disabled
redirectToAppPermissionsSystemSettingsTest
UI test ✅ successfully passed 100x on FirebaseSummary:
• Moved the test from SmokeTest to SettingsPrivacyTest to avoid the retryRule
• Refactored
assertBlockedByAndroid
andassertUnblockedByAndroid
(switched to UIAutomator from Espresso because from time to time was unreliable)• While performing the test runs noticed some timing issues when performing the lots of
pressBack
actions so I've fixed that as wellPull Request checklist
To download an APK when reviewing a PR: