Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test #25803

Merged

Conversation

AndiAJ
Copy link
Collaborator

@AndiAJ AndiAJ commented Jun 29, 2022

For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test ✅ successfully passed 100x on Firebase

Summary:
• Moved the test from SmokeTest to SettingsPrivacyTest to avoid the retryRule
• Refactored assertBlockedByAndroid and assertUnblockedByAndroid (switched to UIAutomator from Espresso because from time to time was unreliable)
• While performing the test runs noticed some timing issues when performing the lots of pressBack actions so I've fixed that as well

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@AndiAJ AndiAJ force-pushed the redirectToAppPermissionsSystemSettingsTest branch 6 times, most recently from e436230 to bd01447 Compare June 30, 2022 13:38
@AndiAJ AndiAJ changed the title Status check disabled redirectToAppPermissionsSystemSettingsTest UI test For #25034 fix disabled redirectToAppPermissionsSystemSettingsTest UI test Jun 30, 2022
@AndiAJ AndiAJ marked this pull request as ready for review June 30, 2022 15:08
@AndiAJ AndiAJ requested review from a team as code owners June 30, 2022 15:08
@AndiAJ AndiAJ self-assigned this Jun 30, 2022
@AndiAJ AndiAJ added the eng:ui-test UI Tests label Jun 30, 2022
@AndiAJ AndiAJ force-pushed the redirectToAppPermissionsSystemSettingsTest branch 6 times, most recently from f212cec to cc03423 Compare July 1, 2022 13:47
@AndiAJ AndiAJ closed this Jul 1, 2022
@AndiAJ AndiAJ reopened this Jul 1, 2022
@AndiAJ AndiAJ added the pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on label Jul 4, 2022
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jul 4, 2022

Flaky on the last run, will check what's going on.

@AndiAJ AndiAJ force-pushed the redirectToAppPermissionsSystemSettingsTest branch 3 times, most recently from a73c2f9 to e42210a Compare July 5, 2022 07:09
@AndiAJ
Copy link
Collaborator Author

AndiAJ commented Jul 5, 2022

Looks like in some cases the "Blocked by Android" remained displayed for "Location" even though the system permission was granted.

Added verifySystemGrantedPermission to be sure that all system permissions are granted and everything is in sync when doing the assertion in Fenix.

✅ Successfully passed 100x on Firebase.

@AndiAJ AndiAJ force-pushed the redirectToAppPermissionsSystemSettingsTest branch from e42210a to 19589e1 Compare July 5, 2022 07:14
@AndiAJ AndiAJ added needs:review PRs that need to be reviewed and removed pr:work-in-progress PRs that are not ready to be reviewed yet and are actively being worked on labels Jul 5, 2022
@mergify
Copy link
Contributor

mergify bot commented Jul 5, 2022

This pull request has conflicts when rebasing. Could you fix it @AndiAJ? 🙏

@AndiAJ AndiAJ force-pushed the redirectToAppPermissionsSystemSettingsTest branch from 19589e1 to 471a99f Compare July 6, 2022 14:44
@AndiAJ AndiAJ added pr:needs-landing PRs that are ready to land [Will be merged by Mergify] and removed needs:review PRs that need to be reviewed labels Jul 6, 2022
@mergify mergify bot merged commit f3def2e into mozilla-mobile:main Jul 7, 2022
@AndiAJ AndiAJ deleted the redirectToAppPermissionsSystemSettingsTest branch July 7, 2022 09:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:ui-test UI Tests pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants