Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #28261 - Rename solo xInteractor parameters in the Tabs Tray to interactor #28400

Merged
merged 2 commits into from
Jan 5, 2023
Merged

For #28261 - Rename solo xInteractor parameters in the Tabs Tray to interactor #28400

merged 2 commits into from
Jan 5, 2023

Conversation

MozillaNoah
Copy link
Contributor

@MozillaNoah MozillaNoah commented Jan 4, 2023

This will be the first PR of 8 or 9 to better land the monolithic tabs tray refactor work I did last summer.

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

QA

  • QA Needed

To download an APK when reviewing a PR (after all CI tasks finished running):

  1. Click on Checks at the top of the PR page.
  2. Click on the firefoxci-taskcluster group on the left to expand all tasks.
  3. Click on the build-debug task.
  4. Click on View task in Taskcluster in the new DETAILS section.
  5. The APK links should be on the right side of the screen, named for each CPU architecture.

GitHub Automation

Fixes #28261

@MozillaNoah MozillaNoah requested review from a team as code owners January 4, 2023 23:09
@gabrielluong gabrielluong added the pr:approved PR that has been approved label Jan 5, 2023
@MozillaNoah MozillaNoah added the pr:needs-landing PRs that are ready to land [Will be merged by Mergify] label Jan 5, 2023
@MozillaNoah MozillaNoah closed this Jan 5, 2023
@MozillaNoah MozillaNoah reopened this Jan 5, 2023
@mergify mergify bot merged commit a2f0580 into mozilla-mobile:main Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pr:approved PR that has been approved pr:needs-landing PRs that are ready to land [Will be merged by Mergify]
Projects
None yet
2 participants