Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

No issue: Fixes string issues for l10n #6158

Merged
merged 1 commit into from
Oct 24, 2019

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Oct 21, 2019


Issues found here: mozilla-l10n/android-l10n#89

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@sblatz sblatz requested a review from Delphine October 21, 2019 18:08
@sblatz sblatz merged commit 2cba624 into mozilla-mobile:master Oct 24, 2019
@codecov-io
Copy link

Codecov Report

Merging #6158 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6158   +/-   ##
=========================================
  Coverage     14.73%   14.73%           
  Complexity      319      319           
=========================================
  Files           262      262           
  Lines         10732    10732           
  Branches       1560     1560           
=========================================
  Hits           1581     1581           
  Misses         9025     9025           
  Partials        126      126
Impacted Files Coverage Δ Complexity Δ
...a/fenix/components/PrivateShortcutCreateManager.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...ozilla/fenix/session/SessionNotificationService.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c98f9...26e76e4. Read the comment docs.

mcarare pushed a commit to mcarare/fenix that referenced this pull request Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants