For #5586 - Adds Logins Telemetry

[ekager]

---

Pull Request checklist

• Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
• Tests: This PR includes thorough tests or an explanation of why it does not
• Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
• Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

• Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

1. click on Show All Checks,
2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
3. click on the "Fenix - assemble" task, then click "Run Artifacts".
4. the APK links should be on the left side of the screen, named for each CPU architecture

[ekager]

Request for data collection review form

All questions are mandatory. You must receive review from a data steward peer on your responses to these questions before shipping new data collection.

1. What questions will you answer with this data?

• How often users let their browser save their logins?
• How often do users manage their saved logins?
• What login management features are used most frequently?
• What login management features are not used often?

2. Why does Mozilla need to answer these questions? Are there benefits for users? Do we need this information to address product or business requirements?

• We want to know how users interact with features related to logins and what features they find most useful (so we can determine whether we need to remove or enhance them)

3. What alternative methods did you consider to answer these questions? Why were they not sufficient?

• N/A (These are baseline metrics)

4. Can current instrumentation answer these questions?

• No, logins is a new feature with no existing telemetry

5. List all proposed measurements and indicate the category of data collection for each measurement, using the Firefox data collection categories on the found on the Mozilla wiki.

• All data is Category 2.

6. How long will this data be collected?

Until 03/01/2020

7. What populations will you measure?

• All release, beta, and nightly users with telemetry enabled.

8. Please provide a general description of how you will analyze this data.

• Glean / Amplitude

9. Where do you intend to share the results of your analysis?

• Only on Glean, Amplitude and with mobile teams.

[codecov-io]

Codecov Report

Merging #6352 into master will increase coverage by 0.04%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##             master   #6352      +/-   ##
===========================================
+ Coverage     16.46%   16.5%   +0.04%     
  Complexity      364     364              
===========================================
  Files           276     275       -1     
  Lines         11292   11262      -30     
  Branches       1618    1620       +2     
===========================================
  Hits           1859    1859              
+ Misses         9280    9250      -30     
  Partials        153     153

Impacted Files	Coverage Δ	Complexity Δ
...la/fenix/components/metrics/GleanMetricsService.kt	7.56% <0%> (-0.22%)	3 <0> (ø)
.../java/org/mozilla/fenix/settings/LoginsFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt	25.45% <0%> (-0.6%)	0 <0> (ø)
...mozilla/fenix/logins/SavedLoginSiteInfoFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...va/org/mozilla/fenix/logins/SavedLoginsFragment.kt	0% <0%> (ø)	0 <0> (ø)	⬇️
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt	0% <0%> (ø)	0% <0%> (ø)	⬇️
...downloads/DownloadNotificationBottomSheetDialog.kt

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d6aeeb2...06b8210. Read the comment docs.

[ekager]

CC @boek / @liuche for data review

[boek]

Data Review Form (to be filled by Data Stewards)

1. Is there or will there be documentation that describes the schema for the ultimate data set in a public, complete, and accurate way?

yes, in metrics.yaml and the generated metrics.md

2. Is there a control mechanism that allows the user to turn the data collection on and off? (Note, for data collection not needed for security purposes, Mozilla provides such a control mechanism) Provide details as to the control mechanism available.

Controlled by Fenix data controls

3. If the request is for permanent data collection, is there someone who will monitor the data over time?

Has expiry

4. Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Type 2, logins interactions.

5. Is the data collection request for default-on or default-off?

Default on

6. Does the instrumentation include the addition of any new identifiers (whether anonymous or otherwise; e.g., username, random IDs, etc. See the appendix for more details)?

No

7. Is the data collection covered by the existing Firefox privacy notice?

Yes

8. Does there need to be a check-in in the future to determine whether to renew the data? (Yes/No) (If yes, set a todo reminder or file a bug if appropriate)**

Has expiry

9. Does the data collection use a third-party collection tool?

No