Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #6308: Remove unecessary telemetry & bump expiry date #7793

Merged
merged 2 commits into from
Jan 17, 2020

Conversation

sblatz
Copy link
Contributor

@sblatz sblatz commented Jan 17, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@codecov-io
Copy link

codecov-io commented Jan 17, 2020

Codecov Report

Merging #7793 into master will increase coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #7793      +/-   ##
============================================
+ Coverage     19.14%   19.16%   +0.01%     
  Complexity      452      452              
============================================
  Files           301      301              
  Lines         11668    11656      -12     
  Branches       1585     1581       -4     
============================================
  Hits           2234     2234              
+ Misses         9249     9237      -12     
  Partials        185      185
Impacted Files Coverage Δ Complexity Δ
...rc/main/java/org/mozilla/fenix/FenixApplication.kt 15.21% <ø> (+0.32%) 2 <0> (ø) ⬇️
...c/main/java/org/mozilla/fenix/home/HomeFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...va/org/mozilla/fenix/components/metrics/Metrics.kt 22.26% <0%> (+0.44%) 0 <0> (ø) ⬇️
...la/fenix/components/metrics/GleanMetricsService.kt 7.89% <0%> (+0.12%) 3 <0> (ø) ⬇️
.../org/mozilla/fenix/settings/about/AboutFragment.kt 0% <0%> (ø) 0 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e4eba42...e21b10e. Read the comment docs.

@sblatz
Copy link
Contributor Author

sblatz commented Jan 17, 2020

Request for Data Collection Renewal

** This form is for the renewal of an existing, reviewed data collection.**

** All questions are mandatory.
You must receive Data Review from a
Data Steward
on a filled-out Request before shipping your renewed data collection.**

  1. Provide a link to the initial Data Collection Review Request for this collection.
  • The data review for each of the items can be found in this document
  1. When will this collection now expire?
  • 2020-09-01
  1. Why was the initial period of collection insufficient?
  • We want to collect this data as our product becomes more mature and our user base changes to see if different patterns arise. Similarly, some of this data had issues being collected (bugs in the telemetry), so we need more time to see if we can draw conclusions.

@sblatz sblatz requested a review from boek January 17, 2020 22:15
@sblatz sblatz added the needs:data-review PR is awaiting a data review label Jan 17, 2020
Copy link
Contributor

@liuche liuche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Data Collection Renewal Review (to be filled by Data Stewards)

  1. Is the provided Data Collection Review complete, correct, and data-review+ by a Data Steward?
    Yes, this product has not launched widely, and irrelevant telemetry has been removed 🎉

  2. Is the data collection covered by the existing Firefox Privacy Notice?
    Yes

@liuche liuche removed the request for review from boek January 17, 2020 23:12
@liuche liuche removed the needs:data-review PR is awaiting a data review label Jan 17, 2020
@liuche liuche merged commit 509fa11 into mozilla-mobile:master Jan 17, 2020
@liuche liuche mentioned this pull request Jan 22, 2020
32 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants