Skip to content
This repository has been archived by the owner on Apr 17, 2021. It is now read-only.

Follow-up: selectively enable elevation on working devices #314

Closed
mcomella opened this issue Sep 30, 2019 · 5 comments
Closed

Follow-up: selectively enable elevation on working devices #314

mcomella opened this issue Sep 30, 2019 · 5 comments
Assignees
Labels

Comments

@mcomella
Copy link
Contributor

Vision statement / What / Requirements

A side effect of #305 was that the toolbar casted a shadow on the initial homescreen on all devices:

device-2019-09-30-141245

I realized we can check each device in code to selectively enable it on the known working devices.

Impact

Acceptance criteria

@mcomella mcomella added the chore label Sep 30, 2019
@mcomella mcomella self-assigned this Sep 30, 2019
mcomella added a commit to mcomella/firefox-echo-show that referenced this issue Oct 1, 2019
mcomella added a commit to mcomella/firefox-echo-show that referenced this issue Oct 1, 2019
mcomella added a commit to mcomella/firefox-echo-show that referenced this issue Oct 1, 2019
mcomella added a commit to mcomella/firefox-echo-show that referenced this issue Oct 1, 2019
@mcomella
Copy link
Contributor Author

mcomella commented Oct 1, 2019

QA: please verify the same steps as #305 (comment). Also, as depicted in the screenshot of the bug for this PR, on the initial homescreen there should be a shadow on the ES5 but not on the ES 1st gen or 2nd gen.

mcomella added a commit that referenced this issue Oct 1, 2019
@nojunpark
Copy link
Contributor

nojunpark commented Oct 10, 2019

@mcomella Seems the opposite - there is a shadow on Echo 2 (the big screen one), but only a line dividing the toolbar and the bottom panel on ES 5 (small screen device)

@nojunpark
Copy link
Contributor

Echo 5:
IMG_20191010_150609
Echo 2:
IMG_20191010_150613

@mcomella
Copy link
Contributor Author

@npark-mozilla This looks like I'd expect.

@nojunpark
Copy link
Contributor

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants