This repository has been archived by the owner on Apr 17, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 12
Follow-up: selectively enable elevation on working devices #314
Labels
Comments
4 tasks
mcomella
added a commit
to mcomella/firefox-echo-show
that referenced
this issue
Oct 1, 2019
mcomella
added a commit
to mcomella/firefox-echo-show
that referenced
this issue
Oct 1, 2019
mcomella
added a commit
to mcomella/firefox-echo-show
that referenced
this issue
Oct 1, 2019
mcomella
added a commit
to mcomella/firefox-echo-show
that referenced
this issue
Oct 1, 2019
QA: please verify the same steps as #305 (comment). Also, as depicted in the screenshot of the bug for this PR, on the initial homescreen there should be a shadow on the ES5 but not on the ES 1st gen or 2nd gen. |
@mcomella Seems the opposite - there is a shadow on Echo 2 (the big screen one), but only a line dividing the toolbar and the bottom panel on ES 5 (small screen device) |
@npark-mozilla This looks like I'd expect. |
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Vision statement / What / Requirements
A side effect of #305 was that the toolbar casted a shadow on the initial homescreen on all devices:
I realized we can check each device in code to selectively enable it on the known working devices.
Impact
Acceptance criteria
The text was updated successfully, but these errors were encountered: