Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert #15142 [v116.4] Undo UA changes that removed FxIOS #16176

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Revert #15142 [v116.4] Undo UA changes that removed FxIOS #16176

merged 1 commit into from
Aug 23, 2023

Conversation

adudenamedruby
Copy link
Contributor

📜 Tickets

Jira ticket
Github issue

💡 Description

Reverting #15142 due to incident. Will find a better solution with a new ticket.

📝 Checklist

You have to check all boxes before merging

  • Filled in the above information (tickets numbers and description of your work)
  • Updated the PR name to follow our PR naming guidelines
  • Wrote unit tests and/or ensured the tests suite is passing
  • When working on UI, I checked and implemented accessibility (minimum Dynamic Text and VoiceOver)
  • If needed I updated documentation / comments for complex code and public methods

@adudenamedruby adudenamedruby requested a review from a team as a code owner August 23, 2023 17:49
@adudenamedruby adudenamedruby changed the title Revert #15142 [v116.4] Revert #15142 [v116.4] Undo UA changes that removed FxIOS Aug 23, 2023
@mobiletest-ci-bot
Copy link

Messages
📖 Edited 1 files
📖 Created 0 files

Generated by 🚫 Danger Swift against c64884e

@adudenamedruby adudenamedruby merged commit d2363e4 into mozilla-mobile:main Aug 23, 2023
10 checks passed
@adudenamedruby
Copy link
Contributor Author

@Mergifyio backport release/v116.2 release/v117

@mergify
Copy link
Contributor

mergify bot commented Aug 23, 2023 •
edited
Loading

backport release/v116.2 release/v117

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Aug 23, 2023
@adudenamedruby @mergify
Revert #15142 [v116.4] Undo UA changes that removed FxIOS (#16176)
8a3aa19 
(cherry picked from commit d2363e4)
This was referenced Aug 23, 2023
Merged
Merged
mergify bot pushed a commit that referenced this pull request Aug 23, 2023
@adudenamedruby @mergify
Revert #15142 [v116.4] Undo UA changes that removed FxIOS (#16176)
5c81666 
(cherry picked from commit d2363e4)
dsmithpadilla pushed a commit that referenced this pull request Aug 23, 2023
@mergify @adudenamedruby
Revert #15142 [v116.4] Undo UA changes that removed FxIOS (#16176) (#…
3b275ab 
…16178)

(cherry picked from commit d2363e4)

Co-authored-by: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
dsmithpadilla pushed a commit that referenced this pull request Aug 23, 2023
@mergify @adudenamedruby
Revert #15142 [v116.4] Undo UA changes that removed FxIOS (#16176) (#…
07226f9 
…16177)

(cherry picked from commit d2363e4)

Co-authored-by: roux g. buciu <11182210+adudenamedruby@users.noreply.github.com>
This was referenced Aug 26, 2023
Closed
Open
This was referenced Sep 9, 2023
Closed
Closed
@data-sync-user data-sync-user mentioned this pull request Dec 22, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbhasin2 nbhasin2 nbhasin2 approved these changes

@OrlaM OrlaM Awaiting requested review from OrlaM

@lmarceau lmarceau Awaiting requested review from lmarceau

@yoanarios yoanarios Awaiting requested review from yoanarios

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adudenamedruby @mobiletest-ci-bot @nbhasin2