Configurable proxy and local sensorthings API #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ferjm
requested changes
Oct 20, 2016
src/config.js
Outdated
|
|
||
| const remoteSTConfig = { | ||
| server: { | ||
| doc: 'SensorThings sandbox API server', |
There was a problem hiding this comment.
nit: if we use something different to SensorUp, this might not be a sandbox anymore :)
src/config.js
Outdated
| default: 'https://pg-api.sensorup.com' | ||
| }, | ||
| path: { | ||
| doc: 'SensorThings sandbox API path', |
src/config.js
Outdated
| }, | ||
| credentials: { | ||
| token: { | ||
| doc: 'SensorThings sandbox API credentials', |
src/routes/sensorthings.js
Outdated
| * You will need to get an access token by creating an account at | ||
| * https://pg.sensorup.com/playground.html | ||
| * | ||
| * Add the access token to your 'sandboxToken' config file entry. |
There was a problem hiding this comment.
Maybe reword this comment to explain that we use SensorUp's for now, but this code is ready to proxy to other ST external services. Also, a comment at the top of the file explaining the local vs remote choices might be helpful.
src/routes/sensorthings.js
Outdated
| }, | ||
| decorateRequest: (proxyReq, originalReq) => { | ||
| // Add SensorUp auth header. | ||
| proxyReq.headers['St-P-Access-Token'] = config.get('sensorthings.remote.credentials.token'); |
There was a problem hiding this comment.
This header is specific to SensorUp. Maybe we need to add a config option for this. Let's keep it simple for now and assume that an external ST service only takes its credentials through a header:
credentials: {
header: 'St-P-Access-Token',
value: 'token'
}
albertopq
force-pushed
the
st-proxy
branch
2 times, most recently
from
57287b3 to
4dc5d98
Compare
|
Looks good! It seems that you need to tweak the tests config file though. |
ferjm
approved these changes
Oct 20, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.