This repository was archived by the owner on Feb 15, 2020. It is now read-only.
add TLS info decoder #210
Merged
add TLS info decoder #210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| function process_message() | ||
| local payload = read_message("Payload") | ||
| local ok, report = pcall(cjson.decode, payload) | ||
| if not ok then return -1, fhr end |
|
DWL if possible, I would like to avoid multidecoders. |
| } | ||
|
|
||
| -- create PEM data from base64 encoded DER | ||
| function make_pem(data) |
There was a problem hiding this comment.
The make_pem, read_cert and parse_cert functions should be local
| local failedCertChain = report["failedCertChain"] | ||
| local ee = nil | ||
| local rootMost = nil | ||
| if failedCertChain and "table" == type(failedCertChain) then |
| end | ||
|
|
||
| -- calculate the clock skew - in seconds, since os.time() returns those | ||
| local reportTime = report["timestamp"] |
There was a problem hiding this comment.
Sorry one more input validation: if reportTime is a boolean true this plugin will crash. If this is a concern its type should be tested.
|
It appears this decode drops submissionDate, without which we lose the ability to partition this data reasonably in S3. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A decoder for extracting key information (clock skew, Subject or SAN / hostname match status and Issuer common name) from TLS error reports.
This requires my modifications to lua-openssl (see zhaozg/lua-openssl#92) - and, for the hostname checks, needs OpenSSL version 1.0.2 (or later). It should still work with an earlier version of OpenSSL but the hostname checks will be omitted.
Feedback welcome.