Skip to content
This repository was archived by the owner on Feb 15, 2020. It is now read-only.

Conversation

trink
Copy link
Contributor

@trink trink commented Apr 10, 2015

No description provided.

@mreid-moz
Copy link
Contributor

Can you rebase this off master?

@trink
Copy link
Contributor Author

trink commented Apr 10, 2015

Why only the last diff is different?

@mreid-moz
Copy link
Contributor

To get rid of the duplicated commits from #55.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The previous data export included the leftover Fields in the output - there are a few things that are not inside the payload that could be useful, though I'm not sure whether they are neccessary or not. geoCountry and Timestamp are likely to be of interest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The goal is to pass back the original structure, correct?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to provide everything in the heka message, with the payload combined back into its original structure.

@trink
Copy link
Contributor Author

trink commented Apr 10, 2015

It is only a github display issue.

@mreid-moz
Copy link
Contributor

I get an error of "error: Failed serializing: bad argument #0 to '?' (must have one string argument)" when trying to use this with the S3 input - is that due to the "raw" message not being properly assigned in the input code?

@trink
Copy link
Contributor Author

trink commented Apr 14, 2015

Yeah, this PR pulls in the Heka with the fix (i.e. you need to build the pipeline with this tag for this encoder to work)

mreid-moz added a commit that referenced this pull request Apr 24, 2015
@mreid-moz mreid-moz merged commit d57172f into master Apr 24, 2015
@trink trink deleted the bugzilla_1149666 branch April 25, 2015 03:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants