Skip to content
This repository was archived by the owner on Jun 16, 2021. It is now read-only.

add dev_start target to entrypoint.sh #35

Merged
merged 1 commit into from
Nov 22, 2017
Merged

add dev_start target to entrypoint.sh #35

merged 1 commit into from
Nov 22, 2017

Conversation

dylanwh
Copy link
Contributor

@dylanwh dylanwh commented Nov 16, 2017

No description provided.

@dylanwh dylanwh requested review from zalun and dklawren November 16, 2017 22:01
@dylanwh dylanwh requested a review from purelogiq November 17, 2017 20:56
purelogiq
purelogiq approved these changes Nov 22, 2017
View reviewed changes
Copy link
Contributor

@purelogiq purelogiq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good, the additional dev_start command is a nice choice to not break existing stuff. We will have to update the dev scripts to call the new command. Thanks!

@dylanwh dylanwh merged commit 0175a54 into mozilla-services:master Nov 22, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@purelogiq purelogiq purelogiq approved these changes

@zalun zalun Awaiting requested review from zalun

@dklawren dklawren Awaiting requested review from dklawren

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dylanwh @purelogiq