Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect spacing between f and i in Fira Mono #170

Closed
romiem opened this issue May 25, 2016 · 6 comments
Closed

Incorrect spacing between f and i in Fira Mono #170

romiem opened this issue May 25, 2016 · 6 comments

Comments

@romiem
Copy link

romiem commented May 25, 2016

As shown in this article, the 'fi' in Sofia, has incorrect spacing between the letters. Even increasing the letter-spacing CSS property through Chrome Inspector fails to add the correct spacing.

http://abduzeedo.com/sofia-luxury-residence-branding

@jfkthame
Copy link
Contributor

jfkthame commented May 25, 2016

That's not (incorrect) spacing, it's an "fi" ligature. Which isn't really appropriate in a monospaced font, and I believe it has been removed from the current version. That site appears to be using the Google Fonts service, and I guess they're still deploying an old release.

(See also issue #14.)

@easyaspi314
Copy link

I don't know about that…

I am pretty sure latest has that; but it is discretionary.
On May 25, 2016 8:21 AM, "jfkthame" notifications@github.com wrote:

That's not (incorrect) spacing, it's an "fi" ligature. Which isn't really
appropriate in a monospaced font, and I believe it has been removed from
the current version. That site appears to be using the Google Fonts
service, and I guess they're still deploying an old release.

(See also issue 14.)


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#170 (comment)

@jfkthame
Copy link
Contributor

But the page indicated above doesn't enable discretionary ligatures, so the fact that it's appearing shows that they're using a font where it is present in the on-by-default 'liga' feature. That shouldn't be the case in the current release, afaik.

@romiem
Copy link
Author

romiem commented May 25, 2016

@jfkthame How were you able to determine if the page above was using discretionary ligatures? Is it configured via a CSS property or perhaps via a querystring parameter when calling the Google Fonts API?

@jfkthame
Copy link
Contributor

In Firefox, you can use the Element Inspector to tinker with CSS properties; if you set

font-variant-ligatures: no-common-ligatures;

on the title element where "Sofia" has the unwanted ligature, you'll see that it decomposes; which indicates that this ligature comes from a Common Ligatures feature in the font.

(Equivalently, setting

font-feature-settings: "liga" off;

would do the same thing, using the low-level OpenType feature tag.)

@romiem
Copy link
Author

romiem commented May 25, 2016

@jfkthame Learn something new everyday! Thanks :)

@romiem romiem closed this as completed May 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants