This repository has been archived by the owner on Jan 12, 2022. It is now read-only.
doc URL fixes! #180
Merged
doc URL fixes! #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes URLs for documentation, so people can actually find the documentation. There is a comment in /urls.py that "/docs are an Apache rewrite", so some of my changes could be rendered perhaps unnecessary (or require a different approach) if the Apache directive was updated.
I did not fix some URLs in /apps/jetpack/fixtures/core_sdk.json , not knowing whether this was just historical (or what it was for), whereas with /apps/jetpack/templates/js/first_addon.js , I changed the URLs as it looked like the widget might still work today, though I didn't test it (and it also used the "new" keyword in front of Widget which I guess is no longer necessary).
Even if this is imperfect, I really suggest addressing this quickly as the whole site is kind of meaningless if one can't find the docs (though "Submit to AMO" is another critical item to make the site worthwhile but at least one can still test without it if one can find the docs).