Skip to content
This repository has been archived by the owner on Feb 29, 2020. It is now read-only.

send Hero Element (TopSites) painted telemetry #2661

Closed
dmose opened this issue Jun 4, 2017 · 4 comments
Closed

send Hero Element (TopSites) painted telemetry #2661

dmose opened this issue Jun 4, 2017 · 4 comments

Comments

@dmose
Copy link
Member

dmose commented Jun 4, 2017

This will (approximately) be adding top_sites_painted_ts to the session telemetry.

Note that doing it will be a bit fun. My suspicion is that the right way to do it is to look at the technique described in http://stackoverflow.com/a/34999925, but to use two requestAnimationFrame's as suggested by #2005 (comment) since rAF is less likely to jank than setTimeout.

@dmose
Copy link
Member Author

dmose commented Jun 5, 2017

As of this writing, the exact data schema is still being sorted out in https://github.com/mozilla/activity-stream/pull/2660/files.

@tspurway
Copy link
Contributor

tspurway commented Jun 5, 2017

This is a measure of the time to when TopSites are available for interaction

@dmose
Copy link
Member Author

dmose commented Jul 10, 2017

There's a user story for the dashboarding of this in #2838.

@dmose dmose self-assigned this Jul 13, 2017
dmose added a commit to dmose/activity-stream that referenced this issue Jul 23, 2017
@dmose dmose added the Has PR label Jul 23, 2017
dmose added a commit to dmose/activity-stream that referenced this issue Jul 25, 2017
dmose added a commit to dmose/activity-stream that referenced this issue Jul 25, 2017
@dmose dmose closed this as completed in 2763d3f Jul 25, 2017
dmose pushed a commit that referenced this issue Jul 25, 2017
send topsites_first_painted_ts (Hero) telemetry (closes #2661)
@dmose
Copy link
Member Author

dmose commented Jul 25, 2017

I've filed #2965 to track the performance of filling in the screenshots for the times when a tab needs that.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants