This repository was archived by the owner on Feb 29, 2020. It is now read-only.
fix(topsites): Combine frecency of the top pages of with/without www instead of all pages #1946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of all pages
ncloudioj
approved these changes
Jan 11, 2017
|
|
||
| // this query does "GROUP BY rev_nowww" (rev_host without www) to remove urls from same domain. | ||
| // GROUP first by rev_host to get the most-frecent page of an exact host | ||
| // then GROUP by rev_nowww to dedupe between top two pages of nowww host. |
There was a problem hiding this comment.
This comment is also a piece of good tongue twister 🥇
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1898. Make sure we combine just the top page instead of all pages with a test. r?@ncloudioj
This change is