This repository has been archived by the owner on Feb 29, 2020. It is now read-only.
feat(topsites): Use different default sites depending on geo #3022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mardak
commented
Jul 31, 2017
| @@ -17,15 +16,18 @@ XPCOMUtils.defineLazyModuleGetter(this, "Screenshots", | |||
|
|
|||
| const TOP_SITES_SHOWMORE_LENGTH = 12; | |||
| const UPDATE_TIME = 15 * 60 * 1000; // 15 minutes | |||
| const DEFAULT_SITES_PREF = "default.sites"; | |||
There was a problem hiding this comment.
k88: Doesn't a . usually denote a branch?
Maybe? I suppose we could have different defaults under that "branch" but one tricky aspect of changing this right now is that all the default test prefs need to be renamed in various files.
k88hudson
approved these changes
Jul 31, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2776. r?@k88hudson
Uses the
getValueof #3021 and updatesTopSitesFeedto watch pref changes instead of just grabbing once on init.