Skip to content

Fix margin bottom on some pages #13844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 3, 2025
+11 −4
Merged

Fix margin bottom on some pages #13844

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/amo/pages/Addon/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,6 @@
@include page-padding;
}

.Addon .Card {
margin-bottom: $padding-page;
}

.Addon-icon-wrapper {
height: 40px;
overflow: hidden;
Expand Down Expand Up @@ -231,3 +227,9 @@
.ContributeCard {
margin: 32px auto;
}

.AddonRecommendations {
// This is the last card in the page, and it doesn't need a `margin-bottom`,
// which `.CardList` adds by default.
margin-bottom: 0;
}
5 changes: 5 additions & 0 deletions src/amo/pages/LandingPage/styles.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

.LandingPage {
@include page-padding;

& > .LandingAddonsCard:last-child {
// The last `.CardList` doesn't need a `margin-bottom`.
margin-bottom: 0;
}
}

.LandingPage-header {
Expand Down