100% coverage #150
Merged
100% coverage #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /* istanbul ignore next */ | ||
| // Looks like you can't ignore a file but you can ignore a function, we don't want coverage here. | ||
| (function defineConfig() { |
There was a problem hiding this comment.
I think you can might be able to using excludes in a .istanbul.yml
There was a problem hiding this comment.
The .istanbul.yml file doesn't appear to be loaded by karma-coverage :(
There was a problem hiding this comment.
I tried looking at this some more and I think it's weird because we only have one file that gets "loaded" (test-runner.js). So it looks like you can ignore a file in the karma conf by making the preprocessors something like src/!(config)/*.js but we just has test-runner.js in there so I don't think there's much we can do.
|
Be nicer not to do the function thing but otherwise r+wc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9537.