Skip to content

Conversation

muffinresearch
Copy link
Contributor

Fixes mozilla/addons#9552

There's no reducers yet but this starts us off with a basic store so that the server doesn't blow up.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 899d294 on muffinresearch:fix-missing-createStore into 2febfb4 on mozilla:master.

import { reducer as reduxAsyncConnect } from 'redux-async-connect';
import createLogger from 'redux-logger';

export default function createStore(initialState = {}) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At some point we should look to DRY this up between the apps.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think at some point we'll only want to include createLogger() when in development and maybe even only on the client (I find it really noisy but sometimes useful in the console). That might be a good time to figure out a good way of doing so.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a comment to #182

@mstriemer
Copy link
Contributor

It looks like src/disco/store.js isn't being included in the coverage checks. I'm guessing because it doesn't have a test file and we're only looking for files in certain folders [1]. Perhaps we should put the store in src/disco/store/index.js just to keep that simple (and add it to test-runner.js.

r+wc+coverage

[1]

'./src/', true, /(actions|api|components|containers|reducers)\/.*\.js$/);

@muffinresearch
Copy link
Contributor Author

I'll definitely fix the coverage in a bit when there's some more code to cover - initially this is just un-breaking it so I can sort out the code splitting.

Ideally we should improve way coverage happens so it's more automatic. We need to think about a good/better way to do that since we need to exclude the server tests.

@muffinresearch muffinresearch merged commit d47114d into mozilla:master Apr 14, 2016
@muffinresearch muffinresearch deleted the fix-missing-createStore branch April 3, 2019 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix missing createStore in disco pane app
3 participants