Fix css/sass build failures #2275
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kumar303
commented
Apr 17, 2017
| before_script: | ||
| # Make sure we have the right node-sass. See: | ||
| # https://github.com/webpack-contrib/css-loader/issues/240#issuecomment-252661267 | ||
| - npm rebuild node-sass |
There was a problem hiding this comment.
This takes 5 seconds which sucks. Any ideas for improvement?
kumar303
changed the title
|
Trying to delete the cache instead to see if that fixes it |
|
Woo! Deleting the Travis cache fixed this instead. |
|
Arrrgh! I didn't think of that. Thanks so much! I'll run through all the old PRs and restart them as needed.
Matthew Riley MacPherson (sent from mobile)
… On 18 Apr 2017, at 18:03, Kumar McMillan ***@***.***> wrote:
Woo! Deleting the Travis cache fixed this instead.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Actually, we'll also need to delete the cache for any PR that is currently failing. There is sadly no 'delete all' button unless I'm missing it. https://travis-ci.org/mozilla/addons-frontend/caches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should stop failures like this from happening: https://travis-ci.org/mozilla/addons-frontend/jobs/222881961
It appears that Travis had some cached artifacts of
node-sasslying around and when it upgraded to a new LTS Node version,node-sasswas left in a broken state.