Skip to content

Conversation

tofumatt
Copy link
Contributor

@tofumatt tofumatt commented May 31, 2017

Fixes mozilla/addons#10437.

I added a note to the adding-a-page.md doc just to mention it's quite out of date... and at least our saga usage is in Categories.js as a stop-gap until we make new docs.

@tofumatt tofumatt requested a review from kumar303 May 31, 2017 22:45
@tofumatt tofumatt changed the title Cover set current user 2495 Cover set current user May 31, 2017
@tofumatt tofumatt changed the title Cover set current user Remove setCurrentUser May 31, 2017
@tofumatt tofumatt force-pushed the cover-set-current-user-2495 branch from f395eef to 9d8a4b1 Compare May 31, 2017 22:55
Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+

[react](https://facebook.github.io/react/docs/getting-started.html) and
[redux](http://redux.js.org/) is assumed.

**Note:** This page is very out-of-date and does not reflect our practices anymore. We now use [redux-saga](https://github.com/redux-saga/redux-saga) for API requests. See `amo/components/Categories.js` for a more modern example of a component that makes API/async requests for data.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, good idea

@tofumatt tofumatt merged commit e008ef1 into master Jun 1, 2017
@tofumatt tofumatt deleted the cover-set-current-user-2495 branch June 1, 2017 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

setCurrentUser action is missing coverage
2 participants