Skip to content

Conversation

tofumatt
Copy link
Contributor

See #2583.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r+wc, thanks

README.md Outdated
| yarn test-coverage | Run all tests and generate code coverage report (Enters [jest][] in `--watch` mode) |
| yarn test-coverage-once | Run all tests, generate code coverage report, then exit |
| yarn test-once | Run all tests with [jest][], then exit |
| yarn test-once | Run all tests with [jest][], run all JS + SCSS linters, then exit |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now that this command no longer lets us send additional args to jest, I think you can simplify the description to:

Run all tests and JS + SCSS linters, then exit

What I mean specifically is that previously you could have done yarn test-once tests/some/file.js but that's no longer possible (which is fine, you can use yarn test for that).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, will do 👍

@tofumatt tofumatt merged commit 7a70218 into master Jun 15, 2017
@tofumatt tofumatt deleted the tofumatt-patch-1 branch June 15, 2017 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants