Skip to content

Fix Disco buttons #2593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 15, 2017
Merged

Fix Disco buttons #2593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d414d93
fix: Fix install button padding in disco pane
tofumatt Jun 15, 2017
26f2119
fix: Fix buttons on disco pane as well
tofumatt Jun 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 0 additions & 26 deletions src/disco/css/Addon.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,20 +53,7 @@ $addon-padding: 20px;
}
}

.Addon-install-button {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these redundant due to markup changes, or is this just controlled elsewhere?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The style is now controlled elsewhere for the most part so these were causing issues.

margin: 0 20px 0 30px;

[dir=rtl] & {
margin: 0 30px 0 20px;
}
}

&:not(.theme) .Addon-install-button {
align-self: stretch;
border-top: 1px solid rgba(0, 0, 0, 0.1);
margin: 0 0 15px;
padding: 15px 20px 0;

> .switch {
float: right;

Expand All @@ -76,19 +63,6 @@ $addon-padding: 20px;
}
}

@include respond-to(large) {
&:not(.theme) .Addon-install-button {
align-self: center;
border: 0;
margin: 0 20px 0 30px;
padding: 0;

[dir=rtl] & {
margin: 0 30px 0 20px;
}
}
}

.logo {
align-items: center;
align-self: stretch;
Expand Down
4 changes: 4 additions & 0 deletions src/disco/css/App.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,3 +248,7 @@ header {
}
}
}

.InstallButton {
@include padding-end(20px);
}