Skip to content

fix: Improve compatibility warning #2600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 16, 2017
Merged

fix: Improve compatibility warning #2600

merged 2 commits into from
Jun 16, 2017

Conversation

tofumatt
Copy link
Contributor

Fix mozilla/addons#10482

Improves the compatibility styling.

Before

screenshot 2017-06-16 15 52 39

After

screenshot 2017-06-16 15 51 34

@tofumatt tofumatt requested a review from kumar303 June 16, 2017 14:53
kumar303
kumar303 approved these changes Jun 16, 2017
View reviewed changes
Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like all you'd have to do is switch ErrorList over to $report-base-color and then you could delete $error-text-color and $error-background-color.

r+wc

@tofumatt tofumatt merged commit cb05c0e into master Jun 16, 2017
@tofumatt tofumatt deleted the non-firefox-issues-2577 branch June 16, 2017 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kumar303 kumar303 kumar303 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add-on detail has layout issues on non-Firefox browsers
2 participants
@tofumatt @kumar303