Different size addon cards #2641
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
force-pushed
the
different-size-addon-cards
branch
2 times, most recently
from
4c8fe37 to
1f56c93
Compare
kumar303
approved these changes
Jun 28, 2017
| top: 0; | ||
| } | ||
|
|
||
| ul.AddonsCard-list { |
There was a problem hiding this comment.
Does this need to have ul in the selector?
There was a problem hiding this comment.
Sadly yes because the CardList styles are a bit too specific. We can clean them up later but for now this is fine 😄
| expect(node.textContent).toEqual(`Rated ${fakeAddon.ratings.average} out of 5`); | ||
| const root = render(); | ||
|
|
||
| expect(root.find('.SearchResult-rating').length).toEqual(1); |
There was a problem hiding this comment.
This could use toHaveLength()
|
I didn't, thanks! Sometimes I |
tofumatt
force-pushed
the
different-size-addon-cards
branch
from
1f56c93 to
d61c557
Compare
tofumatt
force-pushed
the
different-size-addon-cards
branch
from
d61c557 to
638940f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a horizontal result card according to mocks.
Fixes mozilla/addons#10505.
These only appear on desktop; other pages should largely remain the same.
Extensions Landing
Themes Landing