Desktop landing pages #2649
Merged
Desktop landing pages #2649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tofumatt
force-pushed
the
desktop-landing-2561-2562
branch
3 times, most recently
from
a3b7738 to
be5828a
Compare
Fixes #2561 Fixes #2562
tofumatt
force-pushed
the
desktop-landing-2561-2562
branch
from
be5828a to
28f3fe8
Compare
kumar303
approved these changes
Jun 30, 2017
| i18n: Object, | ||
| } | ||
|
|
||
| export class CategoriesHeaderBase extends React.Component { |
There was a problem hiding this comment.
Make sure there's a bug on file to merge this with src/amo/components/Categories
| display: block; | ||
| list-style: none; | ||
| margin: 0 auto; | ||
| padding: 0; |
There was a problem hiding this comment.
I see a couple instances of padding: 0 and margin: 0 in this patch. Are all those necessary? It didn't seem like they were necessary for overrides.
There was a problem hiding this comment.
They're for ul and li items which have default styles. Not sure where we're declaring those but they do exist 😒
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#10469
Fixes mozilla/addons#10470
Mobile
Larger Screens