feat: Add desktop home page #2655
Conversation
tofumatt
force-pushed
the
desktop-home-2565
branch
3 times, most recently
from
f00c093 to
c300190
Compare
|
I wonder if the medium layout should the heading and explantion text aligned to the top of the module rather than vertically centered? |
|
I tried that and it looked kind of awkward:
|
| </h2> | ||
| <p className="Home-description"> | ||
| {i18n.gettext( | ||
| 'Install powerful tools that make browsing faster and safer, add-ons make your browser yours.')} |
There was a problem hiding this comment.
You can use a un-tagged template literal here if that helps with wrapping.
There was a problem hiding this comment.
Oh good call, will do.
| display: block; | ||
| } | ||
|
|
||
| span { |
There was a problem hiding this comment.
Might be nice to move this below the other link styles that come after this.
| } | ||
| } | ||
|
|
||
| .Home-extensions-link:link::before { |
There was a problem hiding this comment.
Not that there's an obvious alternative afaict.
There was a problem hiding this comment.
Yeah I really forget why we're using :link on a styles but my goodness is it frustrating.
| const fakeDispatch = sinon.stub(); | ||
|
|
||
| return shallow( | ||
| <HomeBase |
There was a problem hiding this comment.
Other DIY stores are available
There was a problem hiding this comment.
Hahaha I thought that too. (For those not in the UK)
| ); | ||
| } | ||
|
|
||
| if (clientApp === CLIENT_APP_FIREFOX) { |
There was a problem hiding this comment.
Would be nice to have these work from the API at some point but probably better to do that after cats are consolidated.
There was a problem hiding this comment.
Yeah, the thing is the category API just returns everything... I guess we could request filters on it though.
| const { store } = dispatchSignInActions(); | ||
|
|
||
| const root = findRenderedComponentWithType(renderIntoDocument( | ||
| <Provider store={store}> |
tofumatt
force-pushed
the
desktop-home-2565
branch
from
c300190 to
98f572f
Compare
tofumatt
force-pushed
the
desktop-home-2565
branch
from
98f572f to
fa90fc1
Compare
tofumatt
changed the title
Fix mozilla/addons#10473.
Converts the existing home content to work on desktop... we'll get carousels and such in the future because this was just about porting existing mobile stuff over. But hey–we did it. On the last day. If someone reviews this 😉 😅
Mobile
Medium
Large