Fix mozAddonManager initialization (fixes install switch) #2658
Conversation
|
@tofumatt I tried not to change too much even though this code is a bit gnarly. This patch fixed the issue for me. |
|
Aw crap, this only fixed showing the install button. The install flow is still broken. |
|
Alright, I'll wait to review until the flow is fixed too.
Matthew Riley MacPherson (sent from mobile)
… On 30 Jun 2017, at 15:03, Kumar McMillan ***@***.***> wrote:
Aw crap, this only fixed showing the install button. The install flow is still broken.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
It should be ready for review now. |
|
The most helpful thing would be to test this out locally and make sure it's working -- we need to get it on dev ASAP. Tuesday is a US holiday. @muffinresearch could you help test the patch too? |
|
My flights were a bit delayed but I'm settled and such back home. I should be able to test tonight or tomorrow at the latest 👍 |
|
Just tested it quickly locally for extensions and themes–thus far seems all good. I'll have a look through the code ASAP, thanks for the quick patch. |
There was a problem hiding this comment.
I ran this locally and it worked. As you mentioned, it seems like largely exposing these props to the actual wrapped components and updating them correctly which wasn't happening before.
Thanks for doing some test clean up as well. This works for me, let's get it on -dev so we can get QA to test it.
Seeing your fix I'm sorry I didn't figure that out. Thanks again!
|
Just fixed the conflicts so I can try this out... |
kumar303
force-pushed
the
fix-install-iss2636
branch
from
1ba6176 to
8086cb3
Compare
|
Install looks to work running charles to fake a.m.o for both the amo and discovery apps. |
Fixes mozilla/addons#10504
There are two main problems I'm fixing:
addonprop, the HOC wasn't querying the addon manager for data