Skip to content

Conversation

tofumatt
Copy link
Contributor

@tofumatt tofumatt commented Jul 8, 2017

Closes #2354
Closes #2363

@tofumatt tofumatt force-pushed the greenkeeper/postcss-loader-2.0.6 branch from 904b4f9 to ca13677 Compare July 8, 2017 21:18
@tofumatt tofumatt requested a review from kumar303 July 8, 2017 21:18
@tofumatt
Copy link
Contributor Author

tofumatt commented Jul 8, 2017

Tested locally in dev mode and tested the production build script's CSS output: both are still auto-prefixing appropriately for AMO and not for Disco.

r?

@kumar303
Copy link
Contributor

This needs some lint fixes

@tofumatt tofumatt force-pushed the greenkeeper/postcss-loader-2.0.6 branch from ca13677 to ae63ccf Compare July 10, 2017 14:55
@tofumatt
Copy link
Contributor Author

Ah shoot, right, there are a lot of linting errors I've fixed across branches that have popped up with dep updates :-/

@tofumatt tofumatt force-pushed the greenkeeper/postcss-loader-2.0.6 branch from ae63ccf to d0311c2 Compare July 10, 2017 16:23
@tofumatt
Copy link
Contributor Author

Okay, updated and passes lint now.

Copy link
Contributor

@kumar303 kumar303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a bit more complex but I can't think of anything better. Thanks for digging in and doing the cleanup.

@tofumatt tofumatt merged commit 999278f into master Jul 10, 2017
@tofumatt tofumatt deleted the greenkeeper/postcss-loader-2.0.6 branch July 10, 2017 22:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants