Skip to content

Enter installing state after download ends #2738

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2017
Merged

Enter installing state after download ends #2738

merged 2 commits into from
Jul 11, 2017

Conversation

kumar303
Copy link
Contributor

@kumar303 kumar303 commented Jul 11, 2017 •
edited
Loading

Fixes mozilla/addons#10349

Before the fix:

fix-install-before mov

After the fix:

fix-install-after-cancel mov

Here's another one after the fix that shows confirming the installation:

fix-install-after-confirm mov

@kumar303 kumar303 requested a review from tofumatt July 11, 2017 16:30
tofumatt
tofumatt approved these changes Jul 11, 2017
View reviewed changes
Copy link
Contributor

@tofumatt tofumatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks great!

@kumar303 kumar303 merged commit 82fe436 into mozilla:master Jul 11, 2017
@kumar303 kumar303 deleted the fix-install-state-iss2314 branch July 11, 2017 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@tofumatt tofumatt tofumatt approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Install button doesn't enter installing state
2 participants
@kumar303 @tofumatt