Refactor configuration for server and client #280
Conversation
bin/webpack-dev-server.js
Outdated
| const webpackDevMiddleware = require('webpack-dev-middleware'); | ||
| const webpackHotMiddleware = require('webpack-hot-middleware'); | ||
| const webpackDevConfig = require('config/webpack.dev.config.babel').default; | ||
| const webpackDevConfig = require('../webpack.dev.config.babel').default; |
There was a problem hiding this comment.
This should probably work without ../ following recent changes.
webpack.prod.config.babel.js
Outdated
| import SriStatsPlugin from 'sri-stats-webpack-plugin'; | ||
|
|
||
| import config from './index'; | ||
| const config = require('config'); |
There was a problem hiding this comment.
This could be an import, I'll clean that up in due course.
muffinresearch
force-pushed
the
refactor-config
branch
from
bd61c07 to
558ffd9
Compare
| @@ -0,0 +1,79 @@ | |||
| // CONFIG defaults (aka PRODUCTION) | |||
There was a problem hiding this comment.
On other projects we've made development the default. I guess since this is still no-configuration-needed for development having production default is cool?
There was a problem hiding this comment.
Yeah, I feel it's a better way around to have production config happen if you don't override something than to have development config if you don't override something.
| module.exports = { | ||
| serverPort: 3000, | ||
|
|
||
| apiHost: 'https://addons-dev.allizom.org', |
There was a problem hiding this comment.
I updated this to:
apiHost: process.env.API_HOST || 'https://addons-dev.allizom.org',There was a problem hiding this comment.
Oh that needs to be done differently to use the proper node-config way. I'll update #298.
Fixes mozilla/addons#9569
Fixes mozilla/addons#9565
Fixes mozilla/addons#9559
/src../etc@jasonthomas this will need some modifcations to the deployment since you'll need to specify
NODE_ENVin the deploy scripts after this lands.e.g:
Replacing
devwithstageorproductionfor the other cases anddiscowithsearchfor the search app deployment.