Update jsdom to the latest version 🚀 #2976
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 11.2.0 of jsdom just got published.
The version 11.2.0 is not covered by your current version range.
Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.
I recommend you look into these changes and try to get onto the latest version of jsdom.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.
Commits
The new version differs by 23 commits.
fefa181
Version 11.2.0
c5cc051
Remove unused utils.lengthFromProperties
25cc4e9
Add element.dataset support
89a7ef5
Fully implement semantics 21cad9a Implement HTMLOptionsCollection c2143cc Convert HTMLCollection to IDL 9c56380 Convert NodeList to IDL 18a40f7 Implement FileList's supported prop indices fcd48c2 Always pass the wrapper to parse5 f6bc2ed Re-do a decent amount of XMLHttpRequest stuff 90b32d6 Add "child text content changed steps" and use it for textarea 04d2a4f Rewrite NodeIterator to leverage webidl2js a126b64 Add active check to TreeWalker a33f6a5 Use ASCII case-insensitive matching for class names 4b93d50 Roll web-platform-tests
There are 23 commits in total.
See the full diff
Not sure how things should work exactly?
There is a collection of frequently asked questions and of course you may always ask my humans.
Your Greenkeeper Bot 🌴