-
Notifications
You must be signed in to change notification settings - Fork 400
Fix sign-in while running a server from amo:dev #2977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🎉 💯 Just tested this PR and it works well. Thanks @kumar303. It also works for newly created accounts (which did not work before), except that the user gets redirected to |
@willdurand great, thanks for testing it out. I am reminded now that the redirection 404 (for new accounts) is a known issue that will be fixed when mozilla/addons#10588 lands. However, with my patch you will be logged in when you type in the URL |
Just testing this now, I was beat up by a migraine most of today, sorry! 😢 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested locally and I could also sign in and sign out. Looks good, thank you! 👍
}, | ||
"amo:stage": { | ||
"command": "better-npm-run start-dev", | ||
"command": "better-npm-run start-dev-proxy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shoot! My bad, I think this change was my fault 😢
btw, I also tested add-on/theme installation through a custom Nightly build |
@willdurand be sure to clear your cookies when switching between |
ah good to know, thanks! |
Fixes mozilla/addons#10667
This does a few things:
amo:dev
andamo:stage
go through the proxy which means both the frontend site and the backend API are served on the same domain like production. This should help catch same origin issues locally.amo:dev
amo:stage
(like before) because we need to configure a new FxA client. I'll do that in a follow-up.