-
Notifications
You must be signed in to change notification settings - Fork 400
Add header + fix spec #322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
border-radius: 5px; | ||
display: block; | ||
flex-grow: 0; | ||
margin-left: 50px; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is going to need an alternate rule for RTL. If you express this in flex it will work though. The spec defines a bunch of specific values for these sizes so I think it would be nice to set those in variables and then let flex lay it out correctly.
$blockWidth: 680px;
header {
$videoWidth: 215px;
$videoHeight: 120px;
$spaceBetween: 50px;
display: flex;
justify-content: space-between;
width: $blockWidth;
.content {
width: $blockWidth - $videoWidth - $spaceBetween;
}
.play-video {
display: block;
height: $videoHeight;
width: $videoWidth;
}
}
r+wc |
All the RTL stuff is going to come later. I know there's stuff here that will need changing but we can deal with it then, it won't be a problem to do a quick pass on it once we have a debug RTL locale. |
Fixes mozilla/addons#9581
Fixes mozilla/addons#9583
Fixes mozilla/addons#9584
Future TODOs
I'll file separate issues for any of these bits that we don't already have issues for.