-
Notifications
You must be signed in to change notification settings - Fork 400
Install button states #330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
muffinresearch
merged 1 commit into
mozilla:master
from
muffinresearch:install-buttons-states
May 6, 2016
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,9 +1,5 @@ | ||
import React from 'react'; | ||
import { render } from 'react-dom'; | ||
import { Router, browserHistory } from 'react-router'; | ||
import makeClient from 'core/client/base'; | ||
import routes from './routes'; | ||
import createStore from './store'; | ||
|
||
render( | ||
<Router children={routes} history={browserHistory} />, | ||
document.getElementById('react-view') | ||
); | ||
makeClient(routes, createStore); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
export const DOWNLOADING = 'downloading'; | ||
export const INSTALLED = 'installed'; | ||
export const INSTALLING = 'installing'; | ||
export const UNINSTALLED = 'uninstalled'; | ||
export const UNINSTALLING = 'uninstalling'; | ||
export const UNKNOWN = 'unknown'; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,78 @@ | ||
import React from 'react'; | ||
import { findDOMNode } from 'react-dom'; | ||
import { Simulate, renderIntoDocument } from 'react-addons-test-utils'; | ||
|
||
import InstallButton from 'disco/components/InstallButton'; | ||
import { | ||
DOWNLOADING, | ||
INSTALLED, | ||
INSTALLING, | ||
UNINSTALLED, | ||
UNINSTALLING, | ||
UNKNOWN, | ||
} from 'disco/constants'; | ||
|
||
|
||
describe('<InstallButton />', () => { | ||
function renderButton(props) { | ||
return renderIntoDocument(<InstallButton { ...props } />); | ||
} | ||
|
||
|
||
it('should be disabled if isDisabled addonState is UNKNOWN', () => { | ||
const button = renderButton({addonState: UNKNOWN}); | ||
const root = findDOMNode(button); | ||
const checkbox = root.querySelector('input[type=checkbox]'); | ||
assert.equal(checkbox.hasAttribute('disabled'), true); | ||
assert.ok(root.classList.contains('unknown')); | ||
}); | ||
|
||
it('should reflect UNINSTALLED state', () => { | ||
const button = renderButton({addonState: UNINSTALLED}); | ||
const root = findDOMNode(button); | ||
const checkbox = root.querySelector('input[type=checkbox]'); | ||
assert.equal(checkbox.hasAttribute('disabled'), false); | ||
assert.ok(root.classList.contains('uninstalled')); | ||
}); | ||
|
||
it('should reflect INSTALLED state', () => { | ||
const button = renderButton({addonState: INSTALLED}); | ||
const root = findDOMNode(button); | ||
const checkbox = root.querySelector('input[type=checkbox]'); | ||
assert.equal(checkbox.checked, true, 'checked is true'); | ||
assert.ok(root.classList.contains('installed')); | ||
}); | ||
|
||
it('should reflect download progress', () => { | ||
const button = renderButton({addonState: DOWNLOADING, downloadProgressPercent: 50}); | ||
const root = findDOMNode(button); | ||
assert.ok(root.classList.contains('downloading')); | ||
assert.equal(root.getAttribute('data-download-progress'), 50); | ||
}); | ||
|
||
it('should reflect installation', () => { | ||
const button = renderButton({addonState: INSTALLING}); | ||
const root = findDOMNode(button); | ||
assert.ok(root.classList.contains('installing')); | ||
}); | ||
|
||
it('should reflect uninstallation', () => { | ||
const button = renderButton({addonState: UNINSTALLING}); | ||
const root = findDOMNode(button); | ||
assert.ok(root.classList.contains('uninstalling')); | ||
}); | ||
|
||
it('should call click function passed via prop', () => { | ||
const clickStub = sinon.stub(); | ||
const button = renderButton({addonState: UNINSTALLED, handleClick: clickStub}); | ||
const root = findDOMNode(button); | ||
Simulate.click(root); | ||
assert.ok(clickStub.called); | ||
}); | ||
|
||
it('should throw on bogus state', () => { | ||
assert.throws(() => { | ||
renderButton({addonState: 'BOGUS'}); | ||
}, Error, 'Invalid addonState'); | ||
}); | ||
}); |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these should be namespaced somehow, either just putting them on an
installStates
object or something nice with modules. Once we start adding more constants it's probably going to be convenient to grab all constants of a certain type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok - I think we should see when we need that - we might share most of this and it will just work. Happy to fix it up if it does become unwieldy though.