Add theme preview #344
Merged
Add theme preview #344
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| static propTypes = { | ||
| id: PropTypes.number.isRequired, | ||
| type: PropTypes.string.isRequired, | ||
| accentcolor: PropTypes.string, |
There was a problem hiding this comment.
This looks like it should be camelCased.
There was a problem hiding this comment.
This is the key expected by the theme preview (not sure why) - so I kept it simple rather than making the component have a different key in this case.
I'll do a test and see if it works with camel-case instead if it does we can change it.
There was a problem hiding this comment.
Yep it needs to be the lower-case key.
|
I couldn't set this up to work locally but I trust that it works. r+wc |
muffinresearch
force-pushed
the
add-theme-preview
branch
from
e97eb95 to
e734e21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds theme preview on hover and focus.
Focus styles will need UX input and they probably should be customised and toned down in this specific application.
Fixes mozilla/addons#9585