Update LoginRequired and secure local cookies #345
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
#brokeeverything. I have to run but I'll fix the tests shortly. |
|
So updating the config seems to have no impact on the values that I see pulled out of the config when the tests run. I'm out of ideas for today so I'll try again in the morning. |
|
Things are passing now! Ready for review. |
I wonder if we should consider running dev under ssl since there's so many things that don't work without it? |
|
lgtm r+wc |
|
SSL would be nice in dev, I guess that'd likely mean adding docker for this project. That isn't a huge deal but being able to just use node is kind of nice. We'd be able to run an addons-server a bit easier that way though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates how the
LoginRequiredcomponent works so that it integrates with Helmet a bit better.It also updates it to not use secure cookies in development since that was breaking login persisting.
This doesn't prevent API requests from happening on the server when the user it redirected to login but I will leave that bug open for now. If it needs authentication then it will fail, if it doesn't then the data is public anyway. It's just a performance issue.