Remove footgun from client-config module #360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const clientConfig = new Map(); | ||
| export class ClientConfig { | ||
| constructor(objData) { | ||
| Object.assign(this, { |
There was a problem hiding this comment.
Can you add a comment that this is this way to keep objData private.
There was a problem hiding this comment.
There's a test which should make it obvious if this gets changed. Although I guess someone might rename objData while they're at it and the test would still pass. Maybe the test should check Object.keys(new ClientConfig({})) === ['get', 'has']?
muffinresearch
force-pushed
the
better-client-config
branch
from
0330f96 to
479067f
Compare
muffinresearch
force-pushed
the
better-client-config
branch
from
479067f to
961558a
Compare
|
r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9602
This also means the API for client config now should match node-config.