Add lib to wrap mozAddonManager #368
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/disco/addonManager.js
Outdated
| getAddon() { | ||
| // Resolves a promise with the addon. | ||
| // This will be falsey if the addon wasn't found. | ||
| return this.mozAddonManager.getAddonByID(this.id); |
There was a problem hiding this comment.
Maybe we should have this just reject if the addon is falsey?
src/disco/addonManager.js
Outdated
| } | ||
| // If uninstallation succeeded return the original | ||
| // promise. | ||
| return addonUninstall; |
There was a problem hiding this comment.
This will return a promise that yields true, then? Shouldn't this just return, which would be a promise that resolves with no arguments?
There was a problem hiding this comment.
Yeah I guess that covers both now and the future cases equally.
|
r+wc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9577