Skip to content

Conversation

mstriemer
Copy link
Contributor

One commit with some documentation, one with the page that I made while writing the documentation. That might be weird that the page already exists so you can't really follow it but we'll probably want something like this so I included it.

@mstriemer mstriemer changed the title Document adding pages 309 Document adding pages May 13, 2016
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 223397e on mstriemer:document-adding-pages-309 into 79c16e3 on mozilla:master.

@mstriemer
Copy link
Contributor Author

I noticed that we could abstract the entities reducers like addons and users away entirely. It was really just copy/paste. The best would be to have an entities reducer that nests all of the normlizr entities under entities, so this would impact other parts of the code.

It might be nice to add redux-thunk even though we're using redux-async-connect. I think we'd like to be using thunk instead as it seems more popular, we just need to figure out the server-side rendering bit. Using thunk would allow us to move the loadEntities dispatch into middleware which would clean things up a little.

@muffinresearch
Copy link
Contributor

Good work on starting this now 👍. I know we'd said we wanted some docs but it would have been easy to end-up not getting around to it.

containers/
MyContainer/
index.js
styles.scss
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CSS is currently in its own directory as opposed to being like this next to the JS.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've been putting my CSS next to the JS it belongs to. We should pick one way though. Maybe we should make a list of things we haven't been consistent on and go through it and enforce stuff with eslint/tests.

@mstriemer
Copy link
Contributor Author

Andy suggested putting these on Read the Docs which I think is a good idea. I'll figure out how to get them up there in a bit.

@mstriemer mstriemer merged commit 81c7868 into mozilla:master May 17, 2016
@mstriemer mstriemer deleted the document-adding-pages-309 branch May 17, 2016 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants