Implement error overlay #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/disco/css/Addon.scss
Outdated
| img { | ||
| .message { | ||
| flex-grow: 1; | ||
|
|
There was a problem hiding this comment.
Oops I'll kill this space.
|
Looks good. Keeping it in Changes are good as they are, but I have bigger CSS concerns that I think we should address in another issue. Could merge as is or have some minor fix-ups, your call. r+ |
src/disco/css/Addon.scss
Outdated
|
|
||
| &.theme { | ||
| display: block; | ||
| & .content .copy { |
There was a problem hiding this comment.
The & is superfluous here - I'll remove it.
muffinresearch
force-pushed
the
add-error-message-to-addon-component
branch
from
93eff5b to
519cb41
Compare
muffinresearch
force-pushed
the
add-error-message-to-addon-component
branch
from
519cb41 to
3ec7744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9587
Add the error message display into the Addon component. (It looks like this when enabled):
This could be a separate component which is composed into Addon. I'm not sure if that's necessary in reality though it would be easy enough to move out.
To use this does mean that the Addon component itself will need to become aware of the install state and supply the error message and close action as required. It would be expected that the close action would clear the state back to unknown and thus close the error overlay.
This doesn't yet do any transitioning, we'd want to look at using this [1] for that, and that should be a separate PR.
@mstriemer I'm happy to hear your thoughts on moving this around as needed. The component logic is very simple so re-jigging it would be easy.
[1] https://facebook.github.io/react/docs/animation.html