Interact with install buttons with keyboard only #384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <div className={switchClasses} onClick={this.handleClick} | ||
| data-download-progress={isDownloading ? downloadProgress : 0}> | ||
| <input | ||
| id={slug} |
There was a problem hiding this comment.
I feel like this should reference that it is the install button, install-button-${slug} maybe?
|
r+wc |
muffinresearch
force-pushed
the
install-button-keyboard-a11y
branch
from
7cb41db to
d3e0076
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9601 Fixes mozilla/addons#9600
This makes it possible for a keyboard user to focus and interact with the install button checkboxes.
Notes: You can tab to the buttons and it should be focussed as per the styles above. Hitting spacebar interacts with it which is the same for a normal checkbox.
I'll file some separate bugs re: reflecting the state of the install better for AT users.