Use sinon sandboxes by default #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
test-runner.js
Outdated
| @@ -1,4 +1,5 @@ | |||
| require('babel-polyfill'); | |||
| require('./tests/client/init'); | |||
There was a problem hiding this comment.
I think this should work without the ./
|
r+wc |
|
Does this fix: mozilla/addons#9604? |
|
This doesn't fix mozilla/addons#9604 but the error that was happening there is no longer happening on master. |
|
Mabye the |
mstriemer
force-pushed
the
sinon-sandboxes-275
branch
from
e3783d2 to
a008a5d
Compare
|
It ran the tests against a merge of this branch and master and |
|
Ah ok, makes sense. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes mozilla/addons#9571.