Skip to content

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented May 20, 2016

Fixes mozilla/addons#9620

  • Uses sprintf-js for placeholder subs
  • I forked babel-gettext-extractor and patched it for the following:
  • Made the creation date dynamic
  • Used a babel plugin for dedenting template literals so it gets pre-processed and is therefore correct in the translation.

Next up building some locales with the templates and using them...

Obviously we'll need to clean up and decide how to proceed wrt the plugin fork.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 5655226 on muffinresearch:extract-pot into 2dbe4b7 on mozilla:master.

"Content-Type: text/plain; charset=utf-8\n"

#: src/core/components/LoginPage/index.js:13
msgid "Login Required"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome that this string isn't in the disco one 👍

@mstriemer
Copy link
Contributor

r+wc here. I'm going to look over the patches to the extractor too but we could merge those later if I have any comments.

@muffinresearch muffinresearch merged commit 682b254 into mozilla:master May 20, 2016
@muffinresearch muffinresearch deleted the extract-pot branch May 20, 2016 14:52
@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 558ce49 on muffinresearch:extract-pot into 2dbe4b7 on mozilla:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup locale extraction
3 participants