Skip to content

Set frame-ancestors specifically for disco pane #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 23, 2016
Merged

Set frame-ancestors specifically for disco pane #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion config/default-disco.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,7 @@
module.exports = {};
module.exports = {
CSP: {
directives: {
frameAncestors: ['about:addons'],
},
},
};
21 changes: 21 additions & 0 deletions tests/server/TestCSPConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,3 +91,24 @@ describe('CSP Config', () => {
assert.deepEqual(cspConfig.mediaSrc, ["'none'"]);
});
});


describe('App Specific CSP Config', () => {
afterEach(() => {
process.env.NODE_ENV = 'production';
delete process.env.NODE_APP_INSTANCE;
});

it('should default frame-ancestors to "\'none\'"', () => {
const config = requireUncached('config');
const cspConfig = config.get('CSP').directives;
assert.deepEqual(cspConfig.frameAncestors, ["'none'"]);
});

it('should default set frame-ancestors to about:addons for disco pane', () => {
process.env.NODE_APP_INSTANCE = 'disco';
const config = requireUncached('config');
const cspConfig = config.get('CSP').directives;
assert.deepEqual(cspConfig.frameAncestors, ['about:addons']);
});
});