Skip to content

Relax frame-ancestors to just about: protocol for disco pane #439

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 23, 2016
Merged

Relax frame-ancestors to just about: protocol for disco pane #439

merged 1 commit into from
May 23, 2016

Conversation

muffinresearch
Copy link
Contributor

@muffinresearch muffinresearch commented May 23, 2016 •
edited
Loading

Fixes mozilla/addons#9627

  • x-frame-options are ignored (even if set to DENY) so there's no need to override them for the disco pane
  • Setting just the protocol about: instead of about:addons appears to work modifying the directive via charles.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 57cdd3d on muffinresearch:fix-framing-csp into d0d4376 on mozilla:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 6d20cde on muffinresearch:fix-framing-csp into d0d4376 on mozilla:master.

@muffinresearch muffinresearch merged commit 9ac1063 into mozilla:master May 23, 2016
@muffinresearch muffinresearch deleted the fix-framing-csp branch May 23, 2016 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix frame-ancestors blocking the disco pane loading
2 participants
@muffinresearch @coveralls